feat(preprod): Add analysis_file_id field #93826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
|
This PR has a migration; here is the generated SQL for for --
-- Add field analysis_file_id to preprodartifact
--
ALTER TABLE "sentry_preprodartifact" ADD COLUMN "analysis_file_id" bigint NULL;
CREATE INDEX CONCURRENTLY "sentry_preprodartifact_analysis_file_id_5ed6a408" ON "sentry_preprodartifact" ("analysis_file_id"); |
NicoHinderling
force-pushed
the
add-analysis-file-id-col-to-preprod
branch
from
1b96dce to
11a2874
Compare
trevor-e
approved these changes
Jun 18, 2025
src/sentry/preprod/models.py
Outdated
| @@ -113,6 +113,9 @@ def as_choices(cls): | |||
|
|
|||
| commit = FlexibleForeignKey("sentry.Commit", null=True, on_delete=models.SET_NULL) | |||
|
|
|||
| # Nullable in case the file upload fails | |||
There was a problem hiding this comment.
Size analysis also won't necessarily run for every customer based on quotas.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93826 +/- ##
==========================================
+ Coverage 85.65% 88.02% +2.37%
==========================================
Files 10331 10332 +1
Lines 596435 596405 -30
Branches 23161 23161
==========================================
+ Hits 510869 524983 +14114
+ Misses 85107 70963 -14144
Partials 459 459 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
Add this new field so that we have a reference in the preprod table for which file in filestore is the analysis (treemap)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add this new field so that we have a reference in the preprod table for which file in filestore is the analysis (treemap)