nit(aci): cast detection type config to AlertRuleDetectionType in NOA translation layer
#93835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
mifu67
approved these changes
Jun 18, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93835 +/- ##
===========================================
- Coverage 88.03% 74.83% -13.20%
===========================================
Files 10328 10306 -22
Lines 596106 595177 -929
Branches 23146 23146
===========================================
- Hits 524761 445380 -79381
- Misses 70889 149341 +78452
Partials 456 456 |
auto-merge was automatically disabled
June 18, 2025 18:49
Pull request was converted to draft
iamrajjoshi
force-pushed
the
raj/cast-to-enum
branch
from
16ede52 to
dafed82
Compare
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
…OA translation layer (#93835)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOA expects the
detection_typeto be saved as typeAlertRuleDetectionType, but the detector config is a str, so just casting it