🔧 chore: handle when incident open period model isn't written to #93836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #93836 +/- ##
========================================
Coverage 88.03% 88.03%
========================================
Files 10328 10338 +10
Lines 596106 596539 +433
Branches 23146 23146
========================================
+ Hits 524761 525174 +413
- Misses 70889 70909 +20
Partials 456 456 |
GabeVillalobos
approved these changes
Jun 18, 2025
| workflow_engine_params["alert"] = str(open_period_incident.incident_identifier) | ||
| workflow_engine_params["alert"] = str(open_period_incident.incident_identifier) | ||
| except IncidentGroupOpenPeriod.DoesNotExist as e: | ||
| sentry_sdk.capture_exception(e) |
There was a problem hiding this comment.
Just an FYI, you don't need to call capture_exception with an exception in an except block. It should auto-capture the context already.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the in-between state when Open Periods is getting ready, lets create a sentry exception but still send a notification