feat(aci): Add sorting to monitor list table #93841
Merged
+234
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
malwilley
commented
Jun 18, 2025
| @@ -108,43 +110,4 @@ const RowWrapper = styled('div')<{disabled?: boolean}>` | |||
| opacity: 0.6; | |||
| } | |||
| `} | |||
|
|
|||
| .type, | |||
There was a problem hiding this comment.
Was able to use subgrid here as well (already did so in automations) to get rid of some duplicate grid column definitions
ameliahsu
approved these changes
Jun 18, 2025
| <HeaderCell name="name" sortKey="name" sort={sort}> | ||
| {t('Name')} | ||
| </HeaderCell> | ||
| <HeaderCell name="type" divider sortKey="type" sort={sort}> |
There was a problem hiding this comment.
Are these sortKeys temporary until the API implements more sorting? In the designs I only see the option to sort by Last Issue
There was a problem hiding this comment.
I added all the ones that the API currently supports. When we get the open periods stuff I'll add in the sorting by last issue, but I think it's good to be able to sort by all the columns we can
There was a problem hiding this comment.
That makes sense! As long as the column headers don't get too cramped 😅
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to click column headers to change the sort. This is a little different than tables in other parts of the app since it uses a button element and has hover/pressed states because I wanted it to be obvious which columns were sortable. Will need to extract some of this to use in the automations page as well.