fix(dashboards-comparison): Stringify mismatches and widget_fields sentry tags #93842
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #93842 +/- ##
==========================================
- Coverage 80.38% 76.70% -3.69%
==========================================
Files 10336 10340 +4
Lines 596690 597252 +562
Branches 23186 23186
==========================================
- Hits 479644 458095 -21549
- Misses 116587 138698 +22111
Partials 459 459 |
shruthilayaj
approved these changes
Jun 18, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
…ntry tags (#93842) Both `mismatches` and `widget_fields` tags (being sent to sentry) were arrays and therefore not getting processed properly. I'm stringifying them so we don't get a processing error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
mismatchesandwidget_fieldstags (being sent to sentry) were arrays and therefore not getting processed properly. I'm stringifying them so we don't get a processing error.