feat:(search-bar): Hide asterisk character for contains ops #93848
+122
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
malwilley
reviewed
Jun 18, 2025
| export function formatFilterValue(token: TokenResult<Token.FILTER>['value']): string { | ||
| export function formatFilterValue( | ||
| token: TokenResult<Token.FILTER>['value'], | ||
| allContains = false |
There was a problem hiding this comment.
Instead of adding a second argument, can you make this {token, allContains}?
There was a problem hiding this comment.
Also, I wonder if the naming can be a bit more descriptive for what it is doing in this function. Like stripWildcards or something
| switch (token.type) { | ||
| case Token.VALUE_TEXT: { | ||
| const content = token.value ? token.value : token.text; | ||
| const cleanedContent = allContains ? content.replace(/\*/g, '') : content; |
There was a problem hiding this comment.
This won't work for values that have a wildcard within them like *a*b*c*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the function that formats values being rendered in the search bar so that they won't render the asterisks when all values are considered to be wildcard'ed values.
Example: