feat(aci): connect automation creation form to API #93893
+124
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
scttcper
reviewed
Jun 18, 2025
| @@ -59,6 +59,10 @@ export default function AutomationForm({model}: {model: FormModel}) { | |||
| }); | |||
| const connectedMonitors = monitors.filter(monitor => connectedIds.has(monitor.id)); | |||
|
|
|||
| useEffect(() => { | |||
| model.setValue('detectorIds', Array.from(connectedIds)); | |||
There was a problem hiding this comment.
can we update the model when the connectedIds changes instead of in an effect. Overall, the goal is usually to have as few useEffects as possible.
scttcper
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connected automation form to the API with a new
createAutomation()hook and agetNewAutomationData()helper that combines the form data and automation builder state into the request type that the API expects