fix(trace-eap-waterfall-replay): Unable to load span details #93899
+48
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have multiple traces associated to a replay, and in the replay trace tab we load one trace, and append the rest in batches of three, in to one waterfall.
The error below was happening because, we were using the trace_id of the first trace fetched, to fetch the attributes of all the spans in the waterfall using
/trace-item/..../?trace_id={slug}. Leading to a 404 for spans that are not part of the first trace.Instead of concatenating the fetched results from the batch and appending as one tree, we take the results and individually append them to the tree, hence collecting and passing on the correct traceslugs that the drawer uses to fetch eap span attrs.