Skip to content

Conversation

v-khanna
Copy link

@v-khanna v-khanna commented Aug 7, 2025

Important

Refactor to centralize EXTRACT_EDGES_MAX_TOKENS in helpers.py and update references in edge_operations.py and anthropic_client.py, along with stylistic quote changes.

  • Refactor:
    • Move EXTRACT_EDGES_MAX_TOKENS from edge_operations.py to helpers.py.
    • Update extract_edges in edge_operations.py to use EXTRACT_EDGES_MAX_TOKENS from helpers.py.
    • Update _generate_response in anthropic_client.py to use EXTRACT_EDGES_MAX_TOKENS from helpers.py.
  • Style:
    • Convert single quotes to double quotes in helpers.py, anthropic_client.py, and edge_operations.py for consistency.

This description was created by Ellipsis for 4bbb824. You can customize this summary. It will automatically update as commits are pushed.

@danielchalef
Copy link
Member

danielchalef commented Aug 7, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 4bbb824 in 1 minute and 1 seconds. Click for details.
  • Reviewed 392 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. graphiti_core/helpers.py:40
  • Draft comment:
    EXTRACT_EDGES_MAX_TOKENS is now centralized, reducing duplication. Consider parameterizing it via an environment variable or config if future adjustments are needed.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 80% None
2. graphiti_core/llm_client/anthropic_client.py:40
  • Draft comment:
    String literals have been refactored to use double quotes consistently, which improves code readability and style. The error handling and retry logic remain clear.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 80% None
3. graphiti_core/utils/maintenance/edge_operations.py:121
  • Draft comment:
    Hardcoded token limit replaced with EXTRACT_EDGES_MAX_TOKENS improves maintainability by centralizing token configuration.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 80% None

Workflow ID: wflow_SAzrhUG66qz5wW4F

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@v-khanna
Copy link
Author

v-khanna commented Aug 7, 2025

I have read the CLA Document and I hereby sign the CLA

@v-khanna
Copy link
Author

v-khanna commented Aug 7, 2025

recheck

danielchalef added a commit that referenced this pull request Aug 7, 2025
@v-khanna
Copy link
Author

v-khanna commented Aug 7, 2025

Sorry about that Daniel, not sure why it wasnt signing

danielchalef added a commit that referenced this pull request Aug 25, 2025
AIXerum pushed a commit to AIXerum/graphiti that referenced this pull request Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants