-
Notifications
You must be signed in to change notification settings - Fork 1.8k
refactor: hoist EXTRACT_EDGES_MAX_TOKENS into helpers.py #812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 4bbb824 in 1 minute and 1 seconds. Click for details.
- Reviewed
392
lines of code in3
files - Skipped
0
files when reviewing. - Skipped posting
3
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. graphiti_core/helpers.py:40
- Draft comment:
EXTRACT_EDGES_MAX_TOKENS is now centralized, reducing duplication. Consider parameterizing it via an environment variable or config if future adjustments are needed. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold80%
None
2. graphiti_core/llm_client/anthropic_client.py:40
- Draft comment:
String literals have been refactored to use double quotes consistently, which improves code readability and style. The error handling and retry logic remain clear. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold80%
None
3. graphiti_core/utils/maintenance/edge_operations.py:121
- Draft comment:
Hardcoded token limit replaced with EXTRACT_EDGES_MAX_TOKENS improves maintainability by centralizing token configuration. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold80%
None
Workflow ID: wflow_SAzrhUG66qz5wW4F
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
I have read the CLA Document and I hereby sign the CLA |
recheck |
Sorry about that Daniel, not sure why it wasnt signing |
Important
Refactor to centralize
EXTRACT_EDGES_MAX_TOKENS
inhelpers.py
and update references inedge_operations.py
andanthropic_client.py
, along with stylistic quote changes.EXTRACT_EDGES_MAX_TOKENS
fromedge_operations.py
tohelpers.py
.extract_edges
inedge_operations.py
to useEXTRACT_EDGES_MAX_TOKENS
fromhelpers.py
._generate_response
inanthropic_client.py
to useEXTRACT_EDGES_MAX_TOKENS
fromhelpers.py
.helpers.py
,anthropic_client.py
, andedge_operations.py
for consistency.This description was created by
for 4bbb824. You can customize this summary. It will automatically update as commits are pushed.