Skip to content

Conversation

stifskere
Copy link
Contributor

@stifskere stifskere commented Sep 29, 2024

Changes

This PR contains a few non breaking changes, these are most likely code quality changes and how errors are handled, which basically reduces to

  • Remove unused imports.
  • Install and implement thiserror for every function.
  • Delegated error display to the main function removing usage of expect.
  • Improved code readability by adding line breaks between expressions.
  • Changed moves to references in most places.
  • Changed implementations and respective function names.

Now all the modified functions return their respective Result<_, Err> with their own implementation of thiserror.

@stifskere
Copy link
Contributor Author

I don't really understand how the format is implemented, and why it wouldn't be -o like traditional C compilers, there are no actual expectancy tests so I believe everything works correctly from my tests, it works as before, but the --format argument is quite confusing.

Copy link
Contributor

@SergioRibera SergioRibera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small details that can improve the code a little, but otherwise I like it a lot.

@stifskere stifskere requested a review from SergioRibera October 1, 2024 03:47
@gg0074x gg0074x merged commit 31f00c7 into gg0074x:master Oct 2, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants