adding check if char == '-', if so not using as modifier for keypress #105
Conversation
|
Thanks for the PR! Please sign off your commit message. |
Fixes: https://todo.sr.ht/~eliasnaur/gio/432 Signed-off-by: Jeff Aigner <[email protected]>
|
Done. Please let me know if I've done something incorrectly 🤪 |
io/key/key.go
Outdated
| if chord == "-" { | ||
| modSet, keySet = "", chord | ||
| } else { | ||
| modSet, keySet = chord[:sep], chord[sep+1:] | ||
| } |
There was a problem hiding this comment.
Perhaps I am misreading, but this seems like it would only work to bind to literal presses of -. It doesn't handle modifier keys in combination with - such as Short-- or Ctrl--. Here's a playground demonstrating some of the failure cases. I think whatever we do needs to handle all of the ones I put in the playground, probably by detecting when the final character is - and doing special processing.
There was a problem hiding this comment.
ahh good point. I will be implementing these in my app soon so I'll update the PR when I do so.
|
LGTM, but an addition to |
There was a problem hiding this comment.
Nice work! A test would, as @eliasnaur says, be appreciated. :D
whereswaldon
force-pushed
the
main
branch
4 times, most recently
from
0d543a0 to
1686874
Compare
whereswaldon
force-pushed
the
main
branch
2 times, most recently
from
67c77c9 to
46cc311
Compare
whereswaldon
force-pushed
the
main
branch
2 times, most recently
from
f8029f2 to
026d3f9
Compare
whereswaldon
force-pushed
the
main
branch
11 times, most recently
from
072d68c to
e8ba786
Compare
whereswaldon
force-pushed
the
main
branch
2 times, most recently
from
3d36537 to
74ccc9c
Compare
3 participants
No description provided.