Merge pull request payolapayments#246 from peterkeen/bugfix/payola-can-methods-raise-245

[payolapayments#245] Raise error if methods not implemented

Author: eliotsykes

app/controllers/payola/cards_controller.rb

@@ -31,6 +31,8 @@ def check_modify_permissions
           return_to,
           alert: t('payola.cards.not_authorized')
         ) and return unless self.payola_can_modify_customer?(params[:customer_id])
+      else
+        raise NotImplementedError.new("Please implement ApplicationController#payola_can_modify_customer?")
       end
     end
 

app/controllers/payola/customers_controller.rb

@@ -27,6 +27,8 @@ def check_modify_permissions
           return_to,
           alert: t('payola.customers.not_authorized')
         ) and return unless self.payola_can_modify_customer?(params[:id])
+      else
+        raise NotImplementedError.new("Please implement ApplicationController#payola_can_modify_customer?")
       end
     end
 

app/controllers/payola/subscriptions_controller.rb

@@ -78,6 +78,8 @@ def check_modify_permissions
           confirm_subscription_path(subscription),
           alert: t('payola.subscriptions.not_authorized')
         ) and return unless self.payola_can_modify_subscription?(subscription)
+      else
+        raise NotImplementedError.new("Please implement ApplicationController#payola_can_modify_subscription?")
       end
     end
 

spec/controllers/payola/cards_controller_spec.rb

@@ -136,6 +136,14 @@ module Payola
           expect(response).to redirect_to "/my/cards"
           expect(flash[:alert]).to eq "You cannot modify this customer."
         end
+
+        it "should throw error if controller doesn't define payola_can_modify_customer?" do
+          controller.instance_eval('undef :payola_can_modify_customer?')
+
+          expect {
+            delete :destroy, params: { id: customer.sources.first.id, customer_id: customer.id }
+          }.to raise_error(NotImplementedError)
+      end
       end
 
       it "should raise error when no referrer to redirect to" do

spec/controllers/payola/subscriptions_controller_spec.rb

@@ -227,6 +227,15 @@ module Payola
         expect(response).to redirect_to "/subdir/payola/confirm_subscription/#{@subscription.guid}"
         expect(request.flash[:alert]).to eq 'You cannot modify this subscription.'
       end
+
+      it "should throw error if controller doesn't define payola_can_modify_subscription?" do
+        expect(Payola::UpdateCard).to receive(:call).never
+        controller.instance_eval('undef :payola_can_modify_subscription?')
+
+        expect {
+          post :update_card, params: { guid: @subscription.guid, stripeToken: 'tok_1234' }
+        }.to raise_error(NotImplementedError)
+      end
     end
 
   end

spec/dummy/app/controllers/application_controller.rb

@@ -6,4 +6,8 @@ class ApplicationController < ActionController::Base
   def payola_can_modify_subscription?(subscription)
     true
   end
+
+  def payola_can_modify_customer?(customer)
+    true
+  end
 end