Warn when top-level definition shadows imported value #4672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aayush-tripathi
force-pushed
the
shadow‐import‐warning
branch
from
31ecdd8 to
183f2e3
Compare
lpil
reviewed
Jun 10, 2025
compiler-core/src/analyse.rs
Outdated
| location: c.location, | ||
| name: name.clone(), | ||
| }); | ||
| } |
There was a problem hiding this comment.
Can we move this and the other instance of this block below into a helper method on self please 🙏
compiler-core/src/warning.rs
Outdated
| name | ||
| } => Diagnostic { | ||
| title: format!("`{}` shadows an imported name", name), | ||
| text: format!("Definition of `{}` shadows an imported value.\n\ |
| "thepackage", | ||
| "module", | ||
| r#" | ||
| pub const foo = 1 |
There was a problem hiding this comment.
No foobar please, it's a rather grim WW2 reference.
aayush-tripathi
force-pushed
the
shadow‐import‐warning
branch
from
183f2e3 to
a3dc304
Compare
|
Hi. I have updated the PR. |
Added Warning::TopLevelDefinitionShadowsImport with tests and snapshots
lpil
force-pushed
the
shadow‐import‐warning
branch
from
a3dc304 to
fbbd1e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Warning::TopLevelDefinitionShadowsImport with tests and snapshots
Closes #4666
This PR adds a compiler warning when a top-level function/constant shadows an imported value: