enable allowN and allowAtMost to peek at contents #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In past versions of redis_rate, you could peek at the current state in the redis limiter by calling allowN but not incrementing. The move to lua script did not preserve this (unadvertised) ability. This adds it back, the only issue was trying to SET a redis row with an expiry of zero if the row didn't exist. Since the caller doesn't want to increment at all, this changes the SET to not be called if the value is absent.
|
Looks pretty neat - thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the caller wants to check what's there without mutating it, the lua script doesn't allow it when the row doesn't yet exist, because it tries to set a new row with an expiry of zero. This causes an error like:
I think this approach is in line with what was suggested on #32 -- I changed both scripts to only try and set if the expiry ends up being greater than zero. This should preserve any existing functionality while also re-introducing the ability to peek at rows without altering them. This addresses the case where the row isn't there.