Fix x86 build #37
Closed
Fix x86 build #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* glEnable/glDisable/glIsEnabled handles GL_CLIP_DISTANCE0_APPLE (and only that) * glGetBooleanv/glGetIntegerv/glGetInteger64v/glGetFloatv handles GL_MAX_CLIP_DISTANCES_APPLE * Add gl_ClipDistance to list of built-in variables * Use gl_ClipDistance variable in HLSL translation step with SV_ClipDistance semantics. * Change number of clip planes to 8, as the specification of APPLE_CLIP_DISTANCE requires * PR responses * Allow extension with OpenGLES 2.0 and above * Add static asserts for documentation purposes
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some signed/unsigned mismatches. The x86 configuration treats these warnings as errors. The x64 does not, so I missed those warnings.