Switch from floryn90/hugo to hugomods/hugo image #337
Conversation
julianladisch
force-pushed
the
hugomods
branch
from
384fb70 to
8ab1007
Compare
The site build fails since floryn90/hugo v0.134.3: ``` Error: error building site: failed to acquire a build lock: open /src/.hugo_build.lock: permission denied ``` Cause: The Alpine image has switched from root user to hugo user: floryn90/docker-hugo@b261630 Fix: Switch to hugomods/hugo image that still runs as root user. The hugomods/hugo:std-exts image has git included making our Dockerfile obsolete.
There was a problem hiding this comment.
Pull Request Overview
Switches the Docker configuration from a custom-built image using floryn90/hugo to the hugomods/hugo:std-exts image to resolve permission issues. This change eliminates the need for a custom Dockerfile since the new image includes all required dependencies.
- Replaced custom Docker build with hugomods/hugo:std-exts image
- Simplified docker-compose configuration and documentation
- Removed obsolete Dockerfile
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docker-compose.yaml | Updated to use hugomods/hugo:std-exts image directly, added cache volume mount |
| README.md | Simplified Docker setup instructions by removing build step |
| Dockerfile | Removed entirely as it's no longer needed |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| command: server -D | ||
| volumes: | ||
| - .:/src | ||
| - ./:/src |
There was a problem hiding this comment.
[nitpick] The volume mount syntax ./:/src is inconsistent with the cache mount below which uses absolute path. Consider using .:/src for consistency with typical Docker Compose patterns.
| - ./:/src | |
| - .:/src |
Copilot uses AI. Check for mistakes.
| volumes: | ||
| - .:/src | ||
| - ./:/src | ||
| - ~/hugo_cache:/tmp/hugo_cache |
There was a problem hiding this comment.
Using ~/hugo_cache creates a dependency on the user's home directory. Consider using a named volume or relative path like ./hugo_cache:/tmp/hugo_cache to make the setup more portable across different environments.
| - ~/hugo_cache:/tmp/hugo_cache | |
| - ./hugo_cache:/tmp/hugo_cache |
Copilot uses AI. Check for mistakes.
|
@deining - any comment? |
2 participants
The site build using docker-compose fails since floryn90/hugo v0.134.3:
Cause: The Alpine image has switched from root user to hugo user:
floryn90/docker-hugo@b261630
Fix: Switch to hugomods/hugo image that still runs as root user.
The hugomods/hugo:std-exts image has git included making our Dockerfile obsolete.
Documentation: https://docker.hugomods.com/docs/development/docker-compose/