obm: Match TF output signature argument names. #2565
+148
−121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TF SavedModel picks output names based either on their position or the key in the enclosing dictionary. Orbax Model used to use only positional names. This change updates OBM's logic to match TF SavedModel. The biggest difference is that if the TF function returns a dictionary, or an instance of a registered dataclass, OBM will now pick up its keys and use them as output keys names. This and cl/829521984 should make OBM's TF SavedModel compatible with any tooling that may have depended on the TFSM generated input/output names in `SignatureDef`. PiperOrigin-RevId: 830629964
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
obm: Match TF output signature argument names.
TF SavedModel picks output names based either on their position or the key in the enclosing dictionary. Orbax Model used to use only positional names. This change updates OBM's logic to match TF SavedModel. The biggest difference is that if the TF function returns a dictionary, or an instance of a registered dataclass, OBM will now pick up its keys and use them as output keys names.
This and cl/829521984 should make OBM's TF SavedModel compatible with any tooling that may have depended on the TFSM generated input/output names in
SignatureDef.