Skip to content

Fix issue with INdrStructure type check during unmarshalling and expose authentication context on the RcpConnectedClientTransport class #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 9, 2021
Merged

Fix issue with INdrStructure type check during unmarshalling and expose authentication context on the RcpConnectedClientTransport class #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8f19de1
Fix issue where INdrStructure derived type was not unmarshalled corre…
CCob Mar 9, 2021
580747f
Expose RpcConnectedClientTransport authentication context as a public…
CCob Mar 9, 2021
13c4ee8
Merge branch 'master' of https://github.com/CCob/sandbox-attacksurfac…
CCob Mar 9, 2021
7281aa6
Added XML comment to get rid of compiler warnings.
CCob Mar 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion NtApiDotNet/Ndr/Marshal/NdrUnmarshalBuffer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ public T[] ReadConformantArray<T>() where T : struct
{
return ReadConformantCharArray().Cast<char, T>();
}
else if (typeof(T) == typeof(INdrStructure))
else if (typeof(INdrStructure).IsAssignableFrom(typeof(T)))
{
using (var queue = _deferred_reads.Push())
{
Expand Down
5 changes: 5 additions & 0 deletions NtApiDotNet/Win32/Rpc/Transport/RpcConnectedClientTransport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,6 +482,11 @@ private void BindAuth(Guid interface_id, Version interface_version, Guid transfe
/// </summary>
public RpcAuthenticationLevel AuthenticationLevel => Authenticated ? _transport_security.AuthenticationLevel : RpcAuthenticationLevel.None;

/// <summary>
/// Get the transport authentication context.
/// </summary>
public IClientAuthenticationContext AuthenticationContext => _auth_context;

/// <summary>
/// Get the current Call ID.
/// </summary>
Expand Down