Skip to content

bug fix in <NtFile>.Read(<length>), null is not 0 in RunFileCallSync #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

bug fix in <NtFile>.Read(<length>), null is not 0 in RunFileCallSync #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NtApiDotNet/NtFile.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2379,6 +2379,8 @@ public IEnumerable<FileIdDirectoryEntry> QueryFileIdDirectoryInfo(string file_ma
/// <returns>The length of bytes read into the buffer.</returns>
public NtResult<int> Read(SafeBuffer buffer, long? position, bool throw_on_error)
{
//null is not the same as zero within RunFileCallSync. I did not investigate further than this fix.
position = position ?? 0;
return RunFileCallSync(r => NtSystemCalls.NtReadFile(Handle, r.EventHandle, IntPtr.Zero,
IntPtr.Zero, r.IoStatusBuffer, buffer,
buffer.GetLength(), position.ToLargeInteger(), IntPtr.Zero), throw_on_error)
Expand Down