Update dependencies to latest versions #1039
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the messages the integration tests expect change in more recent versions of Go. Further, the .editorconfig file leads to trailing whitespace being removed. It's a bit of a coin-toss as to whether the right solution here is to override whitespace trimming for just the `testcase` directory or to instead perform some normalization of the expected and actual strings to trim this whitespace, so I did both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make test-all(UNIX) passes. CI will also test thisDescription of change
Update dependencies to the latest versions and build against Go 1.24.
Owing to some changes between Go 1.23 and 1.24, #1038 needs to be merged first to prevent some spurious linter errors from appearing. Note that the same integration test issues I noted in that PR also apply here.
Some of the messages the integration tests expect change in more recent versions of Go.
Further, the .editorconfig file leads to trailing whitespace being removed. It's a bit of a coin-toss as to whether the right solution here is to override whitespace trimming for just the
testcasedirectory or to instead perform some normalization of the expected and actual strings to trim this whitespace, so I did both.Fixes #1027, #1008.
This and #1038 cover some of the same ground as #1032, which is worth revisiting if this and #1038 are merged.