Add alerting rule generator tool #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tool allows us to generate random rules
Revert explicit ./.tools/bin/ paths in Makefile back to using PATH. Improve the genproto replace directive comment to explain the root cause (gogo/status via dskit) and when the workaround can be removed.
moustafab
force-pushed
the
moustafab/add-alerting-gen
branch
from
daa7ff0 to
39e0735
Compare
santihernandezc
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tool allows us to generate random rules
Relates to https://github.com/grafana/alerting-squad/issues/1290
Note on genproto workaround
This PR includes
replacedirectives ingo.modto work around ambiguous imports withgoogle.golang.org/genproto.Root cause
Google split their monolithic
google.golang.org/genprotomodule into separategoogleapis/apiandgoogleapis/rpcmodules. However,github.com/gogo/status(a transitive dependency viadskit) still references the old monolithic module, causing build failures when both versions appear in the dependency graph.The fix
The
replacedirectives force all genproto modules to use compatible versions from the same snapshot, eliminating the ambiguity.When to remove
These directives can be removed once
dskitdrops its dependency ongogo/statusorgogo/statusis updated to use the split modules.