dbo11y: in explain_plan collector grab connection while fetching plan
#3957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The collector issues an `USE` statement to set the schema before running the `EXPLAIN` statement. This requires grabbing a dedicated db connection from the pool to avoid issues with concurrent queries from other collectors that may be running on the same connection.
fridgepoet
approved these changes
Jul 8, 2025
Apparently this path is not covered by tests. I'll look into that as a followup if that's ok. |
|
Happy to help out with any followup tasks if needed, Cristian, just lemme know! |
Sure, if you want to go ahead with adding some specific tests here I'll leave it with you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
The collector issues an
USEstatement to set the schema before running theEXPLAINstatement. This requires grabbing a dedicated db connection from the pool to avoid issues with concurrent queries from other collectors that may be running on the same connection.Which issue(s) this PR fixes
n.a.
Notes to the Reviewer
PR Checklist