Correct secretfilter documented argument types #3958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several types in the arguments configuration documentation were incorrectly specified as maps when they are actually lists.
|
💻 Deploy preview deleted. |
kelnage
changed the title
petewall
approved these changes
Jul 8, 2025
dehaansa
approved these changes
Jul 8, 2025
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-3958-to-release/v1.9 origin/release/v1.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 5e4a59174708d86aea9424d1f06dc8f32afceffd
# Push it to GitHub
git push --set-upstream origin backport-3958-to-release/v1.9
git switch main
# Remove the local backport branch
git branch -D backport-3958-to-release/v1.9Then, create a pull request where the |
dehaansa
pushed a commit
that referenced
this pull request
Jul 8, 2025
Several types in the arguments configuration documentation were incorrectly specified as maps when they are actually lists. (cherry picked from commit 5e4a591)
dehaansa
added a commit
that referenced
this pull request
Jul 8, 2025
Several types in the arguments configuration documentation were incorrectly specified as maps when they are actually lists. (cherry picked from commit 5e4a591) Co-authored-by: Nick Moore <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Several entries (
allowlistandtypes) in the secretfilter Arguments documentation were incorrectly typed as maps when they are actually lists of strings.Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist