database_observability: use tokenizer to extract table names as fallback #3968
+70
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Improve parsing of table names from sql statements by using go-sqllexer as a fallback when the primary parser fails.
This means that there are chances we log a partial list of table names when the sql statement is truncated, but we're heading towards making alloy more resilient and mark statements as deemed unparseable.
Which issue(s) this PR fixes
n.a.
Notes to the Reviewer
PR Checklist