Skip to content

[wip] use zustand-persist #4031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 74 commits into
base: graphiql-5
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
74 commits
Select commit Hold shift + click to select a range
edf3b80
upd
dimaMachina Jun 11, 2025
85e37ae
upd
dimaMachina Jun 11, 2025
f9fa3ef
upd
dimaMachina Jun 12, 2025
fdc800c
upd
dimaMachina Jun 12, 2025
4fdf8df
upd
dimaMachina Jun 12, 2025
65eea18
upd
dimaMachina Jun 12, 2025
50c16f3
upd
dimaMachina Jun 12, 2025
3fc873b
upd
dimaMachina Jun 12, 2025
80f0210
visible plugin
dimaMachina Jun 12, 2025
433f1d1
visible plugin
dimaMachina Jun 12, 2025
1005c59
visible plugin
dimaMachina Jun 12, 2025
9db8f1e
visible plugin
dimaMachina Jun 12, 2025
b6faf05
visible plugin
dimaMachina Jun 12, 2025
e2333d7
Merge branch 'graphiql-5' into storage-key-2
dimaMachina Jun 22, 2025
fa56f25
upd
dimaMachina Jun 22, 2025
dcb58f5
upd
dimaMachina Jun 22, 2025
4a8e5f2
lint
dimaMachina Jun 22, 2025
f7378c8
add storage slice
dimaMachina Jun 22, 2025
429a643
add storage slice
dimaMachina Jun 22, 2025
cd1b7bf
upd
dimaMachina Jun 22, 2025
d4e07db
upd
dimaMachina Jun 22, 2025
fd6d42b
upd
dimaMachina Jun 22, 2025
31ffc69
upd
dimaMachina Jun 22, 2025
25a7af8
upd
dimaMachina Jun 22, 2025
a8824ee
upd
dimaMachina Jun 22, 2025
06c5061
lint
dimaMachina Jun 22, 2025
92dd841
upd
dimaMachina Jun 22, 2025
aa8ed00
fix type errors
dimaMachina Jun 22, 2025
6183871
add ts-expect
dimaMachina Jun 22, 2025
39b2a8a
upd
dimaMachina Jun 22, 2025
a90f932
upd
dimaMachina Jun 22, 2025
3a1273e
upd
dimaMachina Jun 22, 2025
7ac40a9
upd
dimaMachina Jun 22, 2025
a919c2a
upd
dimaMachina Jun 22, 2025
a3f887f
upd
dimaMachina Jun 22, 2025
f21fa94
upd
dimaMachina Jun 22, 2025
9640b26
upd
dimaMachina Jun 22, 2025
4d0c850
upd
dimaMachina Jun 22, 2025
25d80e0
upd resize
dimaMachina Jun 22, 2025
6166ef7
upd provider
dimaMachina Jun 22, 2025
dec8b86
upd provider
dimaMachina Jun 22, 2025
a01ca53
upd provider
dimaMachina Jun 22, 2025
fd7114c
upd toolkit/query.ts
dimaMachina Jun 22, 2025
928b463
upd
dimaMachina Jun 22, 2025
9306b8a
upd [skip ci]
dimaMachina Jun 22, 2025
607f949
upd [skip ci]
dimaMachina Jun 22, 2025
bab8f93
get default tabs state
dimaMachina Jun 22, 2025
fa298dd
tabs cleanup
dimaMachina Jun 22, 2025
3b24b96
upd
dimaMachina Jun 22, 2025
3252b13
remove storeTabs
dimaMachina Jun 22, 2025
ed5567e
upd
dimaMachina Jun 22, 2025
12ab3d5
upd
dimaMachina Jun 22, 2025
b69bfc5
upd
dimaMachina Jun 23, 2025
7ad875f
remove `clearHeadersFromTabs` and `serializeTabState`
dimaMachina Jun 23, 2025
9503865
save showPersistHeadersSettings in storage
dimaMachina Jun 23, 2025
ba0eda9
rm
dimaMachina Jun 23, 2025
fdeb156
fix clear storage
dimaMachina Jun 23, 2025
510ce6d
onChangeEditor
dimaMachina Jun 23, 2025
897e40c
onChangeEditor header editor
dimaMachina Jun 23, 2025
69d4231
upd resize hook
dimaMachina Jun 23, 2025
f2761d7
upd resize hook
dimaMachina Jun 23, 2025
2fc411c
upd query editor
dimaMachina Jun 23, 2025
19300c9
upd
dimaMachina Jun 23, 2025
de16d06
upd
dimaMachina Jun 23, 2025
a2024b9
upd
dimaMachina Jun 23, 2025
686cfe9
remove unused CodeMirror CSS classes from GraphiQL 4
dimaMachina Jun 23, 2025
ab81045
changeset
dimaMachina Jun 23, 2025
0a3734f
upd resize
dimaMachina Jun 23, 2025
22c167e
upd toolkit
dimaMachina Jun 23, 2025
55ba6ee
upd
dimaMachina Jun 23, 2025
e224c48
upd
dimaMachina Jun 23, 2025
3c0407b
prettier
dimaMachina Jun 23, 2025
e6a1a07
upd
dimaMachina Jun 23, 2025
e15b7af
fix response editor
dimaMachina Jun 23, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
save showPersistHeadersSettings in storage
  • Loading branch information
dimaMachina committed Jun 23, 2025
commit 9503865417c63f36c08f1ba517df6e124888339e
1 change: 1 addition & 0 deletions packages/graphiql-react/src/components/provider.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,7 @@ useEffect(() => {
);
return {
activeTabIndex: state.activeTabIndex,
shouldPersistHeaders: state.shouldPersistHeaders,
tabs: state.shouldPersistHeaders
? state.tabs
: state.tabs.map(tab => ({ ...tab, headers: null })),
Expand Down
9 changes: 5 additions & 4 deletions packages/graphiql/src/GraphiQL.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,13 @@ const GraphiQL_: FC<GraphiQLProps> = ({
responseTooltip,
defaultEditorToolsVisibility,
isHeadersEditorEnabled,
showPersistHeadersSettings,
forcedTheme,
confirmCloseTab,
className,

shouldPersistHeaders,
showPersistHeadersSettings = Boolean(shouldPersistHeaders),

children,
...props
}) => {
Expand All @@ -98,9 +100,7 @@ const GraphiQL_: FC<GraphiQLProps> = ({
throw new TypeError('The `readOnly` prop has been removed.');
}
const interfaceProps: GraphiQLInterfaceProps = {
// TODO check if `showPersistHeadersSettings` prop is needed, or we can just use `shouldPersistHeaders` instead
showPersistHeadersSettings:
showPersistHeadersSettings ?? props.shouldPersistHeaders !== false,
showPersistHeadersSettings,
onEditQuery,
onEditVariables,
onEditHeaders,
Expand All @@ -120,6 +120,7 @@ const GraphiQL_: FC<GraphiQLProps> = ({
<GraphiQLProvider
plugins={[...(referencePlugin ? [referencePlugin] : []), ...plugins]}
referencePlugin={referencePlugin}
shouldPersistHeaders={shouldPersistHeaders}
{...props}
>
<HistoryToUse {...(hasHistoryPlugin && { maxHistoryLength })}>
Expand Down
4 changes: 2 additions & 2 deletions packages/graphiql/src/ui/sidebar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ export const Sidebar: FC<SidebarProps> = ({
</VisuallyHidden>
<Dialog.Close />
</div>
{showPersistHeadersSettings ? (
{showPersistHeadersSettings && (
<div className="graphiql-dialog-section">
<div>
<div className="graphiql-dialog-section-title">
Expand Down Expand Up @@ -265,7 +265,7 @@ export const Sidebar: FC<SidebarProps> = ({
</Button>
</ButtonGroup>
</div>
) : null}
)}
{!forcedTheme && (
<div className="graphiql-dialog-section">
<div>
Expand Down