Ensure a grunt bin gets created upon install #1493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
oh neat! |
Member
|
@shama would there be a problem here with npm 2 vs npm 3 because it puts things in random spots? |
Member
Author
|
@vladikoff I tested with both I think I had some artifacts left over from previous tests and I was wrong about it installing the bin. |
Member
|
@shama it seems there is a check in npm for this behaviour, npm3 forces the cli into a subdirectory: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix as just installing
grunt-clias a dependency doesn't actually create the appropriate binary as reported by @vladikoff.@vladikoff could you please review? Thanks!