Skip deletion protection modification for Aurora cluster members #947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mbers - Skip deletion protection changes for RDS cluster members to avoid AWS API errors - Add comprehensive tests for cluster member deletion protection handling - Fix linting issues
james00012
force-pushed
the
fix/-rds-cluster-delete-protection
branch
from
6879620 to
0051fb5
Compare
denis256
previously approved these changes
Oct 8, 2025
|
Changes look ok, but it is failing on lint |
Fix comment alignment in test file to comply with gofmt -s rules. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
denis256
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
RDS instances that are part of Aurora clusters have their deletion protection managed at the cluster level. Attempting to modify deletion protection on individual cluster member instances causes API errors.
This PR addresses two issues:
Fixes deletion protection handling for cluster members: Checks if an RDS instance is part of a cluster before attempting to disable deletion protection. Only standalone instances have their deletion protection modified.
Fixes filtering logic: The previous logic had an inverted condition that caused instances to be excluded when they should be included.
Changes
DBClusterIdentifierDBClusterIdentifieris nil)Testing
Tested with both standalone RDS instances and Aurora cluster members to ensure: