Skip to content

Conversation

@LeonFedotov
Copy link
Contributor

@LeonFedotov LeonFedotov commented Sep 15, 2018

Hey, is this still the active repo?
I needed some "chill" voronoi so iv'e added the relaxation from the demo of the libs you are using http://www.raymondhill.net/voronoi/rhill-voronoi-demo5.html
41321352_2111500258882918_7155172277808847915_n

@hanskellner
Copy link
Owner

Hey @LeonFedotov - Thanks for the update. Yes, this script is still alive. Not sure why I didn't get a notification for this request. Will take a look.

@LeonFedotov
Copy link
Contributor Author

Cool, ive used mixed js style but i can just refactor ecerything into es6... 🙏😇

@LeonFedotov
Copy link
Contributor Author

@hanskellner hey so im willing to write this in the current version of the - what i did was to paste my result from editing the code thats inside the addon on my install, what would you prefer done?

@hanskellner
Copy link
Owner

Hi @LeonFedotov - Sorry for the delay, I'm returning from traveling and will be able to get to it this week.

@hanskellner
Copy link
Owner

HI @LeonFedotov - Changes look great. But there's an issue with Fusion and adding a button to the UI. Fails in the Preview UI and is also randomly failing in the old UI. I'm working to figure out how to fix or a workaround. Thx.

@LeonFedotov
Copy link
Contributor Author

LeonFedotov commented Oct 15, 2018

@hanskellner cool :)
this version works for me as is,
also i would love to add the ability to append the generated curves to the current sketch in edit instead of creating a new sketch.
let me know if you want to do some pair coding, ive been building editors at WIX for a while so i get the architecture.
maybe you can explain your bug a little, do you have a reproduction example that i can try debugging?
cheers!

@hanskellner
Copy link
Owner

@LeonFedotov

i would love to add the ability to append the generated curves to the current sketch in edit instead of creating a new sketch.

Yes, a wish list of mine. And when doing so, be able to specify a point to insert the curves.

let me know if you want to do some pair coding

I'd be up for that.

maybe you can explain your bug a little, do you have a reproduction example that i can try debugging?

I'm in contact with the developers and they are addressing the issue (and saving us time). Part of the problem is the Preview UI and changes to the API. Will post an update when I learn more.

@hanskellner hanskellner merged commit 2cbe262 into hanskellner:master Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants