Skip to content

Conversation

RyanGlScott
Copy link
Member

The type signatures for loadLibrary and loadLibraryEx now refer to HMODULE instead of HINSTANCE for consistency with the official Win32 API documentation. Note that HMODULE and HINSTANCE are both type synonyms for the same thing, so this only changes the presentation of these functions' type signatures, not their behavior.

Fixes #211.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have not added a new Haskell dependency.
  • I have included a changelog entry.
  • I have not modified the version of the package in Win32.cabal.

@Mistuke
Copy link
Contributor

Mistuke commented Aug 18, 2022

Thanks for the patch!

@Mistuke Mistuke self-assigned this Aug 18, 2022
@Mistuke Mistuke self-requested a review August 18, 2022 21:43
@Mistuke Mistuke merged commit 3c26b9b into haskell:master Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change type synonym used in loadLibrary{Ex}'s return type from HINSTANCE to HMODULE

2 participants