Add Semaphore support #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheaf
force-pushed
the
semaphore
branch
4 times, most recently
from
f79d025 to
a5fe8c7
Compare
|
Awesome! This is looking great, let me know whenever you're ready for a review! Thanks! |
Thanks, I think this is ready for review, now that I've got a test checking the functionality. |
This adds the module `System.Win32.Semaphore` which implements Windows semaphores and operations on them. Note that waiting on a semaphore is done using `System.Win32.Event.waitForSingleObject`, and freeing a semaphore is done using `System.Win32.File.closeHandle`.
|
Thanks this looks perfect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for Windows Semaphores. I mostly followed the information on this page and its linked pages.
This is my first time contributing to this library, so there might be some obvious oversights. Thanks.
Motivation and Context
This adds a counterpart to the posix semaphore functionality offered by the
unixpackage, which I am interested in using inghcto improve contention with package-level parallelism.Types of changes
Checklist:
Win32.cabal.