-
Notifications
You must be signed in to change notification settings - Fork 67
Add docs to System.Win32.File and System.Win32.File.Internal #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Mistuke What do you think about such documentation? |
3a88dbb
to
d7431c8
Compare
|
I'm not against it. We've historically not done this because win32 is supposed to be a thin wrapper around the API and we use the exact name as the c API so you can find the docs. That said I can see the appeal of wanting to do this as it makes stuff like language servers report the documentation. However since you are copying significant portions of the text from msdn this triggers copyright issues. The license for these docs seems to be https://github.com/MicrosoftDocs/win32/blob/docs/License, so the text is CC-BY-4.0 and any code MIT. These are compatible licenses with BSD 3 but the terms of the license require the notices and the license be preserved somehow https://github.com/MicrosoftDocs/win32/blob/docs/LICENSE#L210 and so I'm unclear whether this means win32 must also adopt these licenses (and so become triple licensed) Also if you've copied the text from the learn.microsoft.com this is more vague as there's no outgoing license on the site. Only a terms of service that covers everything broadly https://learn.microsoft.com/en-us/legal/termsofuse#notice-specific-to-documents-available-on-this-website For the reasons above I'm going to be cautious here and say this isn't something I can approve on my own. And probably needs some discussion with the CLC. Any opinions @bgamari @RyanGlScott or am I being too paranoid here? |
What about just linking to the relevant learn.microsoft.com URLs? That should avoid copyright issues, and it would avoid needing to keep our Haddocks in sync with upstream changes. |
Yeah I guess it depends on what the goal is. msdn links tend to not be
overly stable. I've had the change in the past. But linking won't get you
haddock which I guess was the purpose of this change.
Sent from my Mobile
…On Sun, 22 Jun 2025, 14:14 Ryan Scott, ***@***.***> wrote:
*RyanGlScott* left a comment (haskell/win32#242)
<#242 (comment)>
What about just linking to the relevant learn.microsoft.com URLs? That
should avoid copyright issues, and it would avoid needing to keep our
Haddocks in sync with upstream changes.
—
Reply to this email directly, view it on GitHub
<#242 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAI7OKLLRMX7NJSPGDUZUK33E2T35AVCNFSM6AAAAAB7V27MF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSOJUGIYDSMZYGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
It's worth noting that commenting It's worth noting that any code located in I think it's worth clarifying my goal. I want to make Windows errors more visible, as well as comments about atomicity within a single volume or other details that are not obvious now. |
To put it simply, the packages above are like |
@Mistuke @RyanGlScott I removed the quote from the text, do you think this is enough? Or can I only leave links? |
I added the final description that I want to see, I think now it makes sense to look at what needs to be cut so as not to have problems with licenses 🤔 |
Description
I want to document the entire repository.
I think this pull request is a good starting point to start writing documentation.
Motivation and Context
I want to add documentation because:
directory
,cabal
,file-io
and so on.Types of changes
Checklist: