gh-305:jackknife_maps takes None as input #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 18, 2025 12:16
cas-crag
changed the title
ntessore
reviewed
Jul 18, 2025
Comment on lines
+47
to
+48
| # This is for eg. XC with systematics maps | ||
| for key_mask in jk_maps.keys(): |
There was a problem hiding this comment.
You are changing the input dictionary here.
Suggested change
| # This is for eg. XC with systematics maps | |
| for key_mask in jk_maps.keys(): | |
| # This is for eg. XC with systematics maps | |
| # Work on a mutable copy of the input | |
| jk_maps = dict(jk_maps) | |
| for key_mask in jk_maps.keys(): |
|
Maybe we could get some ARC student time to help with this: CCMI-CDT/programming-projects#6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #305
Added if-statement to
jackknife_cls()