-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Enable iptables comments for all targets #4391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable iptables comments for all targets #4391
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
c23c6a0 to
37d8388
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 WalkthroughWalkthroughA single kernel configuration option for netfilter comment matching (CONFIG_NETFILTER_XT_MATCH_COMMENT) is added to the generic hassos configuration and removed from the ARM64 Rockchip-specific configuration. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Tbh, I think it prolly makes sense to enable other iptables-related modules for non |
|
Thank you! Sure there is no reason to enable it only for some targets.
I'd rather say the Rockchip fragment deserves a cleanup and enable modules on a justified basis. |
Atm some targets don't have comments support enabled for
iptables. There's no reason to limit that to justarm64-rockhiptarget, so this change addresses that.Summary by CodeRabbit