Skip to content

Conversation

@monosoul
Copy link
Contributor

@monosoul monosoul commented Nov 10, 2025

Atm some targets don't have comments support enabled for iptables. There's no reason to limit that to just arm64-rockhip target, so this change addresses that.

Summary by CodeRabbit

  • Chores
    • Adjusted kernel configuration settings to optimize network filtering support across different platform builds.

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @monosoul

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft November 10, 2025 14:46
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@monosoul monosoul force-pushed the fix/iptables-comments-for-all branch from c23c6a0 to 37d8388 Compare November 10, 2025 14:46
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @monosoul

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@monosoul monosoul marked this pull request as ready for review November 10, 2025 14:48
@home-assistant home-assistant bot dismissed stale reviews from themself November 10, 2025 14:48

Stale

@coderabbitai
Copy link

coderabbitai bot commented Nov 10, 2025

📝 Walkthrough

Walkthrough

A single kernel configuration option for netfilter comment matching (CONFIG_NETFILTER_XT_MATCH_COMMENT) is added to the generic hassos configuration and removed from the ARM64 Rockchip-specific configuration.

Changes

Cohort / File(s) Summary
Kernel Configuration - NETFILTER_XT_MATCH_COMMENT
buildroot-external/kernel/v6.12.y/hassos.config
Added CONFIG_NETFILTER_XT_MATCH_COMMENT=m to enable netfilter comment match target as a loadable module.
Kernel Configuration - NETFILTER_XT_MATCH_COMMENT
buildroot-external/kernel/v6.12.y/kernel-arm64-rockchip.config
Removed CONFIG_NETFILTER_XT_MATCH_COMMENT=m configuration option from ARM64 Rockchip-specific kernel config.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately describes the main change: enabling iptables comments for all targets by adding CONFIG_NETFILTER_XT_MATCH_COMMENT support to hassos.config.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@monosoul
Copy link
Contributor Author

Tbh, I think it prolly makes sense to enable other iptables-related modules for non arm64-rockhip targets too. I'm up for updating the PR in case the maintainers wouldn't mind that.

@sairon sairon added this to the 17.0 milestone Nov 11, 2025
@sairon
Copy link
Member

sairon commented Nov 11, 2025

Thank you! Sure there is no reason to enable it only for some targets.

Tbh, I think it prolly makes sense to enable other iptables-related modules for non arm64-rockhip targets too. I'm up for updating the PR in case the maintainers wouldn't mind that.

I'd rather say the Rockchip fragment deserves a cleanup and enable modules on a justified basis.

@sairon sairon changed the title fix: enable iptables comments for all Enable iptables comments for all targets Nov 11, 2025
@sairon sairon added os linux Linux kernel related issue labels Nov 11, 2025
@sairon sairon merged commit 13b2f05 into home-assistant:dev Nov 11, 2025
3 checks passed
@monosoul monosoul deleted the fix/iptables-comments-for-all branch November 11, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed linux Linux kernel related issue os

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants