Prevent slow turbo frame requests from resetting cookies #1399
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where slow
turbo-frame
requests can inadvertently reset cookies.For example, let's say we have a form that changes the
session
and a<turbo-frame>
that loads a slow endpoint:Here's a potential flow:
<turbo-frame>
starts loading<turbo-frame>
request completes later and resets the session cookie to what it was in step 1.Reproduction: https://github.com/domchristie/turbo_frame_cookies_test
The fix is to cancel the frame's current fetch request when the
<turbo-frame>
disconnects.