feat: Join headers from http/2 requests on http/1 connections #2529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nox
reviewed
Apr 30, 2021
src/proto/h1/role.rs
Outdated
| // https://tools.ietf.org/html/rfc7540#section-8.1.2.5 | ||
| if let Some(joined_cookies) = unsplit_cookie_headers(&msg.head.headers) { | ||
| msg.head.headers.insert(header::COOKIE, joined_cookies); | ||
| } |
There was a problem hiding this comment.
Actually we probably just want to set a boolean value here, and use it later in encode_headers with a new header::COOKIE arm that would prevent writing the header name multiple times, joining them instead, to avoid looking up into the header map and mutating it.
|
I'm not super happy about 58a2930 yet, it feels like alot of repetition. Would appreciate a review on whether that's okay (or needs to be improved further). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2528.
Added a test for the function re-joining the headers, and extended the coercion integration test!