-
Notifications
You must be signed in to change notification settings - Fork 14
chore: Remove unused signature verifier solv6 contract #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR consolidates the SignatureVerifier implementation by removing the duplicate SignatureVerifier.v8.sol file and updating SignatureVerifier.sol to use Solidity 0.8.0. All references throughout the codebase are updated to use the single consolidated implementation.
Key changes:
- Removed duplicate
SignatureVerifier.v8.solfile - Updated
SignatureVerifier.solfrom Solidity 0.6 to 0.8 with modern OpenZeppelin imports - Updated all import statements across facet files to reference the consolidated implementation
- Removed outdated ABI files for legacy interfaces
- Updated configuration files to reflect the consolidation
Reviewed Changes
Copilot reviewed 12 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
hardhat.config.ts |
Removed exclusion of SignatureVerifier.v8.sol from documentation generation |
contracts/facets/SignatureVerifier.v8.sol |
Deleted duplicate v8 implementation file |
contracts/facets/SignatureVerifier.sol |
Updated to Solidity 0.8 with modern dependencies and implementation |
contracts/facets/IexecPocoBoostFacet.sol |
Updated import to reference consolidated SignatureVerifier |
contracts/facets/IexecPocoAccessorsFacet.sol |
Updated import to reference consolidated SignatureVerifier |
contracts/facets/IexecPoco2Facet.sol |
Updated import to reference consolidated SignatureVerifier |
contracts/facets/IexecPoco1Facet.sol |
Updated import to reference consolidated SignatureVerifier |
contracts/facets/IexecOrderManagementFacet.sol |
Updated import to reference consolidated SignatureVerifier |
docs/uml/*.svg |
Regenerated UML diagrams reflecting the consolidated architecture |
abis/human-readable-abis/* |
Removed ABI files for legacy ERC interfaces no longer directly imported |
.solcover.js |
Removed skip directive for SignatureVerifier.sol to enable coverage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #315 +/- ##
=======================================
Coverage 96.53% 96.53%
=======================================
Files 32 32
Lines 1069 1069
Branches 213 213
=======================================
Hits 1032 1032
Misses 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.