createCollection() SDK method

[cedric25]

No description provided.

[cedric25]

Trying something here to slow down this file growth: the method file will own its types, just re-exporting them here.

[cedric25]

Trying something here to slow down types.ts file growth: the method file will own its types as we can see here.

[PierreJeanjacquot]

I aggree, maybe extracting common types in from types from types.ts to avoid circular imports

flowchart
  TYPES(types.ts) --> COMMON(common-types.ts)
  MODULE_1(createCollection.ts) --> COMMON
  TYPES --> MODULE_1
  MODULE_2(xxx.ts) --> COMMON
  TYPES --> MODULE_2

Loading

[PierreJeanjacquot]

good job, see the comments for improvement suggestions

[PierreJeanjacquot]

I aggree, maybe extracting common types in from types from types.ts to avoid circular imports

flowchart
  TYPES(types.ts) --> COMMON(common-types.ts)
  MODULE_1(createCollection.ts) --> COMMON
  TYPES --> MODULE_1
  MODULE_2(xxx.ts) --> COMMON
  TYPES --> MODULE_2

Loading

[PierreJeanjacquot]

As tokenid is an uint256 in the ABI mintedTokenId is going to be a bigint. Assuming we are using a sequence for collectionIds, we can safely cast it into a number that will fit into safe integers.

Suggested change

	const mintedTokenId = transactionReceipt.logs.find(
	({ eventName }) => eventName === 'Transfer'
	)?.args[2];
	return {
	collectionId: mintedTokenId,
	};
	const mintedTokenId = transactionReceipt.logs.find(
	({ eventName }) => eventName === 'Transfer'
	)?.args[2];
	return {
	collectionId: Number(mintedTokenId),
	};

[cedric25]

Would it make sense to add as bigint line 37 to better understand the Number casting line 40?

[PierreJeanjacquot]

yes! It will make it clearer