Skip to content

feature/manage-sell #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 41 commits into from
Feb 1, 2024
Merged

feature/manage-sell #130

merged 41 commits into from
Feb 1, 2024

Conversation

@Le-Caignec
Copy link
Contributor

@Le-Caignec Le-Caignec commented Jan 22, 2024 •
edited
Loading

Smart Contract :

  • Develop Sale.sol contract ✅
  • add removeProtectedDataFromSubscription function ✅
  • add modifier for subscription : onlyCollectionNotSubscribed & onlyProtectedDataNotAvailableInSubscription ✅
  • add modifier for renting : onlyProtectedDataNotRented & onlyProtectedDataNotForRenting ✅
  • refactor wording tenants to renters ✅

Tests :

  • add corresponding tests for Sale contract ✅
  • modify & add tests for Subscription contract with the new modifiers ✅

PierreJeanjacquot
PierreJeanjacquot reviewed Jan 22, 2024
View reviewed changes
PierreJeanjacquot
PierreJeanjacquot requested changes Jan 30, 2024
View reviewed changes
PierreJeanjacquot
PierreJeanjacquot reviewed Feb 1, 2024
View reviewed changes
@Le-Caignec Le-Caignec merged commit 754cdd6 into v2 Feb 1, 2024
@Le-Caignec Le-Caignec deleted the feature/manage-sell branch February 1, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PierreJeanjacquot PierreJeanjacquot PierreJeanjacquot approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Le-Caignec @PierreJeanjacquot