Skip to content

Feature/consume protected data #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 57 commits into from
Feb 6, 2024
Merged

Feature/consume protected data #133

merged 57 commits into from
Feb 6, 2024

Conversation

@Le-Caignec
Copy link
Contributor

@Le-Caignec Le-Caignec commented Jan 23, 2024 •
edited
Loading

  • add new appRegistry (many refactor)
  • change registry to protectedDataRegistry
  • add require in consumeProtectedData function
  • add tests

Base automatically changed from feature/manage-sell to v2 February 1, 2024 10:28
PierreJeanjacquot
PierreJeanjacquot reviewed Feb 5, 2024
View reviewed changes
Copy link
Member

@PierreJeanjacquot PierreJeanjacquot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first batch of comments for the sake of being reactive, I didn't dive that much into the code

PierreJeanjacquot
PierreJeanjacquot requested changes Feb 6, 2024
View reviewed changes
@Le-Caignec Le-Caignec merged commit ad5e834 into v2 Feb 6, 2024
@Le-Caignec Le-Caignec deleted the feature/consumeProtectedData branch February 6, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PierreJeanjacquot PierreJeanjacquot PierreJeanjacquot approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Le-Caignec @PierreJeanjacquot