Feature/create cnft method #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implement config that define the default ipfs gateway
*implement error types
*implement observable and safeObserver classes to handle Confidential NFT building process
*implement validation errors
*implement ipfs service that allow the upload of cNFT data to ipfs
*implement logger service that allows to log different phases of the built of the CNFT
*implement the core sdk method to be able to create Confidential NFTs
*implement the sdk class
*You can now import the library and call the function iExecDataprotector.createCNFTWithObservable that allows to handle complex operations and follow the different steps of the creation.
abbesBenayache
approved these changes
Mar 20, 2023
PierreJeanjacquot
requested changes
Mar 21, 2023
Member
PierreJeanjacquot
left a comment
PierreJeanjacquot
left a comment
There was a problem hiding this comment.
To change:
- remove dead code and dependencies
- reuse logic by importing the observable method in the promise
To think about:
- maybe validate user inputs (data & name)
- using
ipfslib to upload is likely to stop working anytime soon, you may need to find a replacement solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.