Skip to content

Conversation

@PierreJeanjacquot
Copy link
Member

@PierreJeanjacquot PierreJeanjacquot commented Apr 25, 2023

  • type: fully type protectData and protectDataObservable
    • the dataSchema returned by protectData is now a DataSchema instead of a string to enable to type check it and make it easier to work with in TS
export type DataSchemaEntryType =
   | 'boolean'
   | 'number'
   | 'string'
   | MimeType;
 export interface DataSchema
   extends Record<string, DataSchema | DataSchemaEntryType> {}
  • refacto: reuse signer and provider from iexec SDK instead of instantiating new ones
  • fix: added error cases to schema extraction for unsupported type of data

@PierreJeanjacquot PierreJeanjacquot marked this pull request as ready for review April 27, 2023 19:15
Copy link
Contributor

@Le-Caignec Le-Caignec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works perfectly with all demo.But i listed some improve may be

@Le-Caignec Le-Caignec self-requested a review April 28, 2023 09:56
Copy link
Contributor

@Le-Caignec Le-Caignec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RAS

@PierreJeanjacquot PierreJeanjacquot merged commit 3cf3aa6 into develop Apr 28, 2023
@PierreJeanjacquot PierreJeanjacquot deleted the fix/refacto-protect-data branch April 28, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants