add voucher deployment on local test stack #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisccastillo
force-pushed
the
feature/voucher-test-stack
branch
from
ce038ef to
d347251
Compare
luisccastillo
force-pushed
the
feature/voucher-test-stack
branch
10 times, most recently
from
0d2f37b to
18643bf
Compare
luisccastillo
force-pushed
the
feature/voucher-test-stack
branch
from
18643bf to
c4bd57b
Compare
PierreJeanjacquot
requested changes
May 21, 2024
Member
PierreJeanjacquot
left a comment
PierreJeanjacquot
left a comment
There was a problem hiding this comment.
we can remove a lot of complexity that is useless in the context of this repo, see refactoring proposals in comments.
Member
There was a problem hiding this comment.
also report this change in the root .drone
Member
There was a problem hiding this comment.
convert into TS if possible :)
Comment on lines
19
to
65
| export const TEST_CHAINS = { | ||
| 'bellecour-fork': { | ||
| rpcURL: DRONE ? 'http://bellecour-fork:8545' : 'http://localhost:8545', | ||
| chainId: '134', | ||
| sconeSmsURL: DRONE ? 'http://sms:13300' : 'http://localhost:13300', | ||
| gramineSmsURL: DRONE | ||
| ? 'http://sms-gramine:13300' | ||
| : 'http://localhost:13309', | ||
| iexecGatewayURL: DRONE ? 'http://market-api:3000' : 'http://localhost:3000', | ||
| resultProxyURL: DRONE | ||
| ? 'http://result-proxy:13200' | ||
| : 'http://localhost:13200', | ||
| pocoAdminWallet: new Wallet( | ||
| '0x564a9db84969c8159f7aa3d5393c5ecd014fce6a375842a45b12af6677b12407' | ||
| ), | ||
| faucetWallet: new Wallet( | ||
| '0xde43b282c2931fc41ca9e1486fedc2c45227a3b9b4115c89d37f6333c8816d89' | ||
| ), | ||
| voucherHubAddress: VOUCHER_HUB_ADDRESS, // TODO: change with deployment address once voucher is deployed on bellecour | ||
| voucherManagerWallet: new Wallet( | ||
| '0x2c906d4022cace2b3ee6c8b596564c26c4dcadddf1e949b769bcb0ad75c40c33' | ||
| ), | ||
| voucherSubgraphURL: DRONE | ||
| ? 'http://gaphnode:8000/subgraphs/name/bellecour/iexec-voucher' | ||
| : 'http://localhost:8000/subgraphs/name/bellecour/iexec-voucher', | ||
| debugWorkerpool: 'debug-v8-bellecour.main.pools.iexec.eth', | ||
| debugWorkerpoolOwnerWallet: new Wallet( | ||
| '0x800e01919eadf36f110f733decb1cc0f82e7941a748e89d7a3f76157f6654bb3' | ||
| ), | ||
| prodWorkerpool: 'prod-v8-bellecour.main.pools.iexec.eth', | ||
| prodWorkerpoolOwnerWallet: new Wallet( | ||
| '0x6a12f56d7686e85ab0f46eb3c19cb0c75bfabf8fb04e595654fc93ad652fa7bc' | ||
| ), | ||
| provider: new JsonRpcProvider( | ||
| DRONE ? 'http://bellecour-fork:8545' : 'http://localhost:8545' | ||
| ), | ||
| defaults: { | ||
| hubAddress: '0x3eca1B216A7DF1C7689aEb259fFB83ADFB894E7f', | ||
| ensRegistryAddress: '0x5f5B93fca68c9C79318d1F3868A354EE67D8c006', | ||
| ensPublicResolverAddress: '0x1347d8a1840A810B990d0B774A6b7Bb8A1bd62BB', | ||
| isNative: true, | ||
| useGas: false, | ||
| name: 'bellecour', | ||
| }, | ||
| isAnvil: true, | ||
| }, | ||
| }; |
Member
There was a problem hiding this comment.
we don't need this TEST_CHAINS map because we only work with one chain, plus a lot of configuration is not needed for this repo.
luisccastillo
force-pushed
the
feature/voucher-test-stack
branch
from
60c2cea to
381569c
Compare
luisccastillo
force-pushed
the
feature/voucher-test-stack
branch
from
381569c to
d38f399
Compare
| @@ -0,0 +1 @@ | |||
| export const VOUCHER_HUB_ADDRESS = '0x959922bE3CAee4b8Cd9a407cc3ac1C251C2007B1'; | |||
Member
There was a problem hiding this comment.
Suggested change
| export const VOUCHER_HUB_ADDRESS = '0x959922bE3CAee4b8Cd9a407cc3ac1C251C2007B1'; | |
| export const VOUCHER_HUB_ADDRESS = 'TO_BE_DEPLOYED'; |
… voucher-test-stack-refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.