Skip to content

Fix/enhance constructor #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
May 25, 2023
Merged

Fix/enhance constructor #40

merged 16 commits into from
May 25, 2023

Conversation

@PierreJeanjacquot
Copy link
Member

@PierreJeanjacquot PierreJeanjacquot commented May 17, 2023 •
edited
Loading

Constructor:

  • remove redundant provider config (included in iexecOptions)
  • remove (useless on bellecour) triple block confirmation
  • fully type constructor args (using iexec sdk types)

Other:

  • upgrade iexec sdk to benefit from type fixes
    • base types exports
    • Dataserorder tag typing issue
  • fix bad any typing on revokeAllAccessObservable: (args: RevokeAllAccessParams) => Observable<any>
  • format GrantedAccess from Datasetorder outputted by iexec sdk
  • factorize revokeOneAccess logic in revokeAllAccessObservable

@PierreJeanjacquot PierreJeanjacquot marked this pull request as ready for review May 24, 2023 15:06
Le-Caignec
Le-Caignec requested changes May 25, 2023
View reviewed changes
Copy link
Contributor

@Le-Caignec Le-Caignec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

juste deux améliorations possibles mais pas gênant !

@PierreJeanjacquot PierreJeanjacquot merged commit 578055f into develop May 25, 2023
@PierreJeanjacquot PierreJeanjacquot deleted the fix/enhance-constructor branch May 25, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Le-Caignec Le-Caignec Le-Caignec approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PierreJeanjacquot @Le-Caignec