syntax highlighting & client-side querying #27
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pushes all the work of requesting the Gist's contents, rendering them, applying the correct syntax highlighting and sanitizing the HTML to the client.
general thoughts reg. this approach
Advantages:
castratelimit the web app to 2500 requests / hour (5000 / 2), if the client does the work of querying GitHub we can pull in however much information we wantDisadvantages:
In general I think it's a great improvement since it greatly simplifies everything that happens on the server and even though I prefer doing Python over JS, it's nicer to have everything in one place instead of having it split between python on the server and JS on the client and constantly making sure the 2 match up.