Skip to content

Move problems to a folder and beautify main class #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 9, 2018
Merged

Move problems to a folder and beautify main class #9

merged 2 commits into from
Nov 9, 2018

Conversation

ignacio-chiazzo
Copy link
Owner

@ignacio-chiazzo ignacio-chiazzo commented Nov 5, 2018 •
edited
Loading

  • Move all problems within a shared class called LeetcodeProblems.
  • Dynamically load classes within ~/LeetcodeProblems folder.
  • Added settings for VSCode

ignacio-chiazzo
ignacio-chiazzo commented Nov 5, 2018
View reviewed changes
Main.js
}
})
});
}
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GAKINDUSTRIES You might have good ideas of better patterns to use here.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge this, we can discuss this later though

@ignacio-chiazzo ignacio-chiazzo merged commit f22a4f5 into master Nov 9, 2018
@ignacio-chiazzo ignacio-chiazzo deleted the folderize branch December 5, 2018 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GAKINDUSTRIES GAKINDUSTRIES Awaiting requested review from GAKINDUSTRIES

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ignacio-chiazzo