Skip to content

Conversation

dimaMachina
Copy link
Collaborator

@dimaMachina dimaMachina commented Oct 13, 2025

Screen.Recording.2025-10-16.at.20.20.07.mov

Copy link

changeset-bot bot commented Oct 13, 2025

🦋 Changeset detected

Latest commit: c451310

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@inkeep/agents-manage-ui Major
@inkeep/agents-cli Major
@inkeep/agents-manage-api Major
@inkeep/agents-run-api Major
@inkeep/agents-core Major
@inkeep/agents-sdk Major
@inkeep/create-agents Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 13, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
agents-manage-api Ready Ready Preview Comment Oct 17, 2025 10:03pm
agents-manage-ui Ready Ready Preview Comment Oct 17, 2025 10:03pm
agents-run-api Ready Ready Preview Comment Oct 17, 2025 10:03pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
agents-docs Skipped Skipped Oct 17, 2025 10:03pm

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

Copy link

claude bot commented Oct 13, 2025

Claude encountered an error —— View job


PR Review in Progress

Analyzing the animated graph edge implementation. I'll provide comprehensive feedback as a TypeScript Staff Engineer and System Architect.

Todo List

  • Read all changed files to understand the implementation
  • Explore existing edge types and patterns for consistency
  • Analyze the animated circles edge component
  • Review integration points and architectural considerations
  • Check for performance, security, and maintainability concerns
  • Provide comprehensive review feedback

@dimaMachina dimaMachina marked this pull request as ready for review October 16, 2025 21:25
Copy link
Contributor

@sarah-inkeep sarah-inkeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, a few notes:

  • Could we actually remove the checkmark on the tool, now that I see it in action I think it might be a little confusing (sorry for suggesting we add it)
  • For the ball on the edges could we make it so it only travels down the edge once instead of recurring?
  • After the tool completes can we show the ball moving back up the edge (in the other direction) to illustrate the data going back to the agent
  • There is an agent_initializing data-operation, could we add the glow to that agent when that operation happens?
  • Could we also add the ball for transfer operations?
  • Could we make whichever agent or tool is active have the glow effect and then have it stop glowing when it is complete:
    for delegation: if agent a delegates to agent b they can both be glowing
    but for transfer: if agent a transfers to agent b then only agent b would be glowing

Basically I think we want the ball to reflect directionality of the data and the glow to reflect the active agent or tool if that make sense. Happy to talk through this on a call as well.

const onDataOperation: EventListenerOrEventListenerObject = (event) => {
// @ts-expect-error -- improve types
const { conversationId, timestamp, ...data } = event.detail;
console.log('Data operation:', data);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove this console log? also I think conversationId and timestamp are unused so maybe we could remove those as well

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Could we actually remove the checkmark on the tool, now that I see it in action I think it might be a little confusing (sorry for suggesting we add it)

yep, I think without is better! removed

Copy link
Collaborator Author

@dimaMachina dimaMachina Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • For the ball on the edges could we make it so it only travels down the edge once instead of recurring?

yep, I think you are right too.
It was tricky to fix it. I need to add effect:

  const ref = useRef<SVGAnimateElement>(null);

  // Without this useEffect, the animation won't start when this component is rendered dynamically.
  useEffect(() => {
    ref.current?.beginElement();
  }, []);

to run it once

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an agent_initializing data-operation, could we add the glow to that agent when that operation happens?

hmm, agent_initializing sends only global agent id, it doesn't sends weather-assistant agentId

Screenshot 2025-10-17 at 14 54 59

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also add the ball for transfer operations?

Which agent do you use? How can I reproduce this event type? for now I was able to receive only following event types

agent_initializing
delegation_sent
tool_call
tool_result
agent_generate
delegation_returned
completion

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you click on the edge between the agents and change the relationship to "transfer" instead of delegate, then you should see it.
Screenshot 2025-10-17 at 9 43 24 AM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, agent_initializing sends only global agent id, it doesn't sends weather-assistant agentId
ah got it, maybe we can highlight the default agent then, I believe the default agent is the entry point for each graph.

Copy link
Contributor

@sarah-inkeep sarah-inkeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants