feat: Add round-trip validation for inkeep pull #699
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements comprehensive validation for
inkeep pull
that ensures generated TypeScript files can be serialized back to match the original backend data.This addresses the duplication issue where pull validation logic was reimplementing parts of push conversion logic. Now both commands share the same serialization path.
Changes
Core Utilities
Shared Project Loader (
agents-cli/src/utils/project-loader.ts
)loadProject()
function used by both push and pull commandsDeep JSON Comparison (
agents-cli/src/utils/json-comparison.ts
)FullProjectDefinition
objects field-by-fieldValidation
pull.ts
)inkeep push
project.getFullDefinition()
Updated Commands
Pull Command
Push Command
loadProject()
utilityTesting & Documentation
Comprehensive Test Suite (
agents-cli/src/commands/__tests__/pull-validation.test.ts
)Updated Documentation (
agents-docs/content/docs/typescript-sdk/cli-reference.mdx
)Benefits
✅ Eliminates Duplication - Reuses
toFullProjectDefinition()
logic from push✅ Better Validation - Ensures generated TS is actually correct
✅ Catches Errors Early - LLM generation issues detected before push
✅ Maintainability - Single source of truth for TS → JSON conversion
✅ Confidence - Guarantees pull → push round-trip works correctly
Testing
Example Output
Success:
Failure:
🤖 Generated with Claude Code