Skip to content

Conversation

@imgbot
Copy link

@imgbot imgbot bot commented Mar 5, 2021

Beep boop. Your images are optimized!

Your image file size has been reduced by 5% 🎉

Details
File Before After Percent reduction
/source/Governance/adlink.svg 57.67kb 16.56kb 71.28%
/source/Tutorials/Topics/topic_stats_rqt.png 48.91kb 16.88kb 65.48%
/source/Tutorials/Turtlesim/new_pen.png 8.51kb 5.43kb 36.26%
/source/Governance/TierIV.png 47.68kb 30.68kb 35.66%
/source/Governance/openrobotics-logo-stacked.png 24.01kb 16.95kb 29.39%
/source/Governance/eprosima.svg 15.44kb 11.10kb 28.13%
/source/Tutorials/Turtlesim/remap.png 9.71kb 6.98kb 28.09%
/source/Governance/rover.png 8.96kb 6.66kb 25.64%
/source/Tutorials/Turtlesim/turtlesim.png 7.63kb 5.69kb 25.37%
/source/Governance/microsoft.svg 10.42kb 7.96kb 23.53%
/source/Governance/amazon.svg 8.96kb 6.88kb 23.22%
/source/Releases/eloquent-small.png 33.29kb 25.70kb 22.82%
/source/Governance/robotis.png 28.44kb 22.41kb 21.21%
/source/Tutorials/Services/spawn.png 9.91kb 7.82kb 21.13%
/source/Governance/windriver.png 10.64kb 8.46kb 20.47%
/source/Tutorials/Turtlesim/set_pen.png 41.71kb 33.20kb 20.41%
/source/Tutorials/Services/clear.png 9.80kb 7.87kb 19.74%
/source/Tutorials/Ros2bag/playback.png 9.40kb 7.69kb 18.16%
/source/Tutorials/Turtlesim/spawn.png 40.51kb 33.21kb 18.03%
/source/Tutorials/Ros2bag/record.png 8.56kb 7.03kb 17.83%
/source/Tutorials/Launch-Files/mimic.png 13.67kb 11.25kb 17.70%
/source/Tutorials/Turtlesim/rqt.png 37.00kb 30.54kb 17.45%
/source/Governance/gvsc.png 5.52kb 4.58kb 16.95%
/source/Tutorials/Topics/pub_stream.png 8.78kb 7.36kb 16.15%
/source/Releases/dashing-small.png 18.99kb 15.93kb 16.13%
/source/Governance/picknik.jpg 33.80kb 28.44kb 15.87%
/source/Governance/apex.png 11.24kb 9.48kb 15.67%
/source/Tutorials/Parameters/set.png 7.73kb 6.52kb 15.65%
/source/Tutorials/Workspace/underlay.png 7.76kb 6.59kb 15.12%
/source/Tutorials/Topics/pub_once.png 8.34kb 7.11kb 14.85%
/source/Releases/foxy-small.png 41.66kb 35.50kb 14.78%
/source/Tutorials/Workspace/overlay.png 8.60kb 7.33kb 14.68%
/source/Releases/ardent-small.png 31.76kb 28.53kb 10.15%
/source/Tutorials/Rqt-Console/warn.png 69.57kb 63.50kb 8.74%
/source/Tutorials/Topics/debug.png 91.22kb 84.67kb 7.18%
/source/Governance/ubuntu.svg 5.73kb 5.33kb 7.00%
/source/Tutorials/Rqt-Console/info.png 49.35kb 46.00kb 6.79%
/source/Tutorials/Topics/rqt_graph2.png 89.27kb 83.61kb 6.35%
/source/Tutorials/Topics/rqt_graph3.png 97.23kb 91.28kb 6.13%
/source/Governance/lge.svg 99.06kb 93.16kb 5.96%
/source/Tutorials/Launch-Files/mimic_graph.png 57.95kb 54.80kb 5.43%
/source/Governance/tri_logo_landscape-web.svg 5.27kb 4.99kb 5.32%
/source/Tutorials/Topics/unhide.png 118.54kb 113.08kb 4.61%
/source/Governance/intel.svg 2.96kb 2.85kb 3.57%
/source/Releases/crystal-small.png 4.98kb 4.81kb 3.49%
/source/Tutorials/Topics/Topic-MultiplePublisherandMultipleSubscriber.gif 1,932.18kb 1,873.32kb 3.05%
/source/Tutorials/Topics/Topic-SinglePublisherandSingleSubscriber.gif 1,021.84kb 993.28kb 2.79%
/source/Tutorials/Topics/rqt_graph.png 82.23kb 80.22kb 2.44%
/source/Tutorials/Rqt-Console/console.png 45.04kb 44.07kb 2.15%
/source/Tutorials/Services/Service-SingleServiceClient.gif 371.36kb 364.49kb 1.85%
/source/Governance/samsung.svg 1.70kb 1.67kb 1.56%
/source/Tutorials/Services/Service-MultipleServiceClient.gif 877.41kb 865.25kb 1.39%
/source/Tutorials/URDF/r2d2_rviz_demo.gif 204.64kb 202.26kb 1.16%
/source/Governance/bosch_75h.jpg 570.04kb 569.09kb 0.17%
Total : 6,472.57kb 6,126.06kb 5.35%

Black Lives Matter | 💰 donate | 🎓 learn | ✍🏾 sign

📝 docs | :octocat: repo | 🙋🏾 issues | 🏅 swag | 🏪 marketplace

*Total -- 6,472.57kb -> 6,126.06kb (5.35%)

/source/Governance/adlink.svg -- 57.67kb -> 16.56kb (71.28%)
/source/Tutorials/Topics/topic_stats_rqt.png -- 48.91kb -> 16.88kb (65.48%)
/source/Tutorials/Turtlesim/new_pen.png -- 8.51kb -> 5.43kb (36.26%)
/source/Governance/TierIV.png -- 47.68kb -> 30.68kb (35.66%)
/source/Governance/openrobotics-logo-stacked.png -- 24.01kb -> 16.95kb (29.39%)
/source/Governance/eprosima.svg -- 15.44kb -> 11.10kb (28.13%)
/source/Tutorials/Turtlesim/remap.png -- 9.71kb -> 6.98kb (28.09%)
/source/Governance/rover.png -- 8.96kb -> 6.66kb (25.64%)
/source/Tutorials/Turtlesim/turtlesim.png -- 7.63kb -> 5.69kb (25.37%)
/source/Governance/microsoft.svg -- 10.42kb -> 7.96kb (23.53%)
/source/Governance/amazon.svg -- 8.96kb -> 6.88kb (23.22%)
/source/Releases/eloquent-small.png -- 33.29kb -> 25.70kb (22.82%)
/source/Governance/robotis.png -- 28.44kb -> 22.41kb (21.21%)
/source/Tutorials/Services/spawn.png -- 9.91kb -> 7.82kb (21.13%)
/source/Governance/windriver.png -- 10.64kb -> 8.46kb (20.47%)
/source/Tutorials/Turtlesim/set_pen.png -- 41.71kb -> 33.20kb (20.41%)
/source/Tutorials/Services/clear.png -- 9.80kb -> 7.87kb (19.74%)
/source/Tutorials/Ros2bag/playback.png -- 9.40kb -> 7.69kb (18.16%)
/source/Tutorials/Turtlesim/spawn.png -- 40.51kb -> 33.21kb (18.03%)
/source/Tutorials/Ros2bag/record.png -- 8.56kb -> 7.03kb (17.83%)
/source/Tutorials/Launch-Files/mimic.png -- 13.67kb -> 11.25kb (17.7%)
/source/Tutorials/Turtlesim/rqt.png -- 37.00kb -> 30.54kb (17.45%)
/source/Governance/gvsc.png -- 5.52kb -> 4.58kb (16.95%)
/source/Tutorials/Topics/pub_stream.png -- 8.78kb -> 7.36kb (16.15%)
/source/Releases/dashing-small.png -- 18.99kb -> 15.93kb (16.13%)
/source/Governance/picknik.jpg -- 33.80kb -> 28.44kb (15.87%)
/source/Governance/apex.png -- 11.24kb -> 9.48kb (15.67%)
/source/Tutorials/Parameters/set.png -- 7.73kb -> 6.52kb (15.65%)
/source/Tutorials/Workspace/underlay.png -- 7.76kb -> 6.59kb (15.12%)
/source/Tutorials/Topics/pub_once.png -- 8.34kb -> 7.11kb (14.85%)
/source/Releases/foxy-small.png -- 41.66kb -> 35.50kb (14.78%)
/source/Tutorials/Workspace/overlay.png -- 8.60kb -> 7.33kb (14.68%)
/source/Releases/ardent-small.png -- 31.76kb -> 28.53kb (10.15%)
/source/Tutorials/Rqt-Console/warn.png -- 69.57kb -> 63.50kb (8.74%)
/source/Tutorials/Topics/debug.png -- 91.22kb -> 84.67kb (7.18%)
/source/Governance/ubuntu.svg -- 5.73kb -> 5.33kb (7%)
/source/Tutorials/Rqt-Console/info.png -- 49.35kb -> 46.00kb (6.79%)
/source/Tutorials/Topics/rqt_graph2.png -- 89.27kb -> 83.61kb (6.35%)
/source/Tutorials/Topics/rqt_graph3.png -- 97.23kb -> 91.28kb (6.13%)
/source/Governance/lge.svg -- 99.06kb -> 93.16kb (5.96%)
/source/Tutorials/Launch-Files/mimic_graph.png -- 57.95kb -> 54.80kb (5.43%)
/source/Governance/tri_logo_landscape-web.svg -- 5.27kb -> 4.99kb (5.32%)
/source/Tutorials/Topics/unhide.png -- 118.54kb -> 113.08kb (4.61%)
/source/Governance/intel.svg -- 2.96kb -> 2.85kb (3.57%)
/source/Releases/crystal-small.png -- 4.98kb -> 4.81kb (3.49%)
/source/Tutorials/Topics/Topic-MultiplePublisherandMultipleSubscriber.gif -- 1,932.18kb -> 1,873.32kb (3.05%)
/source/Tutorials/Topics/Topic-SinglePublisherandSingleSubscriber.gif -- 1,021.84kb -> 993.28kb (2.79%)
/source/Tutorials/Topics/rqt_graph.png -- 82.23kb -> 80.22kb (2.44%)
/source/Tutorials/Rqt-Console/console.png -- 45.04kb -> 44.07kb (2.15%)
/source/Tutorials/Services/Service-SingleServiceClient.gif -- 371.36kb -> 364.49kb (1.85%)
/source/Governance/samsung.svg -- 1.70kb -> 1.67kb (1.56%)
/source/Tutorials/Services/Service-MultipleServiceClient.gif -- 877.41kb -> 865.25kb (1.39%)
/source/Tutorials/URDF/r2d2_rviz_demo.gif -- 204.64kb -> 202.26kb (1.16%)
/source/Governance/bosch_75h.jpg -- 570.04kb -> 569.09kb (0.17%)

Signed-off-by: ImgBotApp <[email protected]>
@pull-request-quantifier-deprecated

Pull Request Quantified (Extra Large)

This PR has 1324 quantified lines of changes. In general, a change size of 50 to 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +8 -1316
Percentile : 100%

Total files changed: 8

Change summary by file extension:
.svg : +8 -1316

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants