Make fewer allocations in QueryContext(). #2349
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a simple query like `SELECT * FROM t WHERE id = $1`,
QueryContext() used to make 6 allocations on average.
Reduce that to 4 by avoiding two allocations that
are immediately discarded:
// the variadic arguments of c.conn.Query() escape,
// so args is heap-allocated
args := []any{databaseSQLResultFormats}
// append() reallocates args to add enough space +
// an array returned by namedValueToInterface()
// is immediately discarded
args = append(args, namedValueToInterface(argsV)...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a simple query like
SELECT * FROM t WHERE id = $1, QueryContext() used to make 6 allocations on average. Reduce that to 4 by avoiding two allocations thatare immediately discarded:
// the variadic arguments of c.conn.Query() escape,
// so args is heap-allocated
args := []any{databaseSQLResultFormats}
// append() reallocates args to add enough space +
// an array returned by namedValueToInterface()
// is immediately discarded
args = append(args, namedValueToInterface(argsV)...)