Skip to content

Conversation

@louis-jan
Copy link
Contributor

Describe Your Changes

This PR fixes issue where app returns a few providers only.

Fixes Issues

  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

Copilot AI review requested due to automatic review settings November 12, 2025 06:30
Copilot finished reviewing on behalf of louis-jan November 12, 2025 06:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where providers with empty model arrays were being filtered out during the provider initialization process, causing the app to return only a subset of available providers.

  • Removes an early return that filtered out providers when their models array was empty
  • Allows providers with empty models arrays to be properly included in the list of available providers

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

Barecheck - Code coverage report

Total: 29.99%

Your code coverage diff: 0.00% ▴

Uncovered files and lines
FileLines
web-app/src/services/providers/tauri.ts5-13, 15-16, 18-19, 21-28, 30-32, 34-40, 42-46, 48-70, 73-75, 77-86, 88-89, 91-120, 122-127, 129-132, 134-137, 141-146, 149-152, 154-158, 161-164, 166, 168-185, 187, 190, 192-195, 197-202, 204-214, 217-222, 224-231, 234-238, 241-245, 247-272

@louis-jan louis-jan merged commit bc777fd into release/v0.7.3 Nov 12, 2025
20 checks passed
@louis-jan louis-jan deleted the fix/do-not-filter-out-providers-by-models-length branch November 12, 2025 06:55
@github-actions github-actions bot added this to the v0.7.4 milestone Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants